From 0709f10f59c8cf4a64cf112d2711c75f013c7523 Mon Sep 17 00:00:00 2001 From: Howard Wu Date: Mon, 6 Mar 2023 21:18:38 +0800 Subject: [PATCH] Enable Xposed API call protection by default (#2423) --- app/src/main/res/values/strings.xml | 2 +- .../java/org/lsposed/lspd/service/ConfigManager.java | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 0d48ddb4..f25fe339 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -209,7 +209,7 @@ Beta Nightly build Xposed API call protection - Block dynamically loaded module code to use Xposed API, this may break some modules but benefit security (experimental feature) + Block dynamically loaded module code to use Xposed API, this may break some modules but benefit security Readme diff --git a/daemon/src/main/java/org/lsposed/lspd/service/ConfigManager.java b/daemon/src/main/java/org/lsposed/lspd/service/ConfigManager.java index 0cceb3a8..b8ec051f 100644 --- a/daemon/src/main/java/org/lsposed/lspd/service/ConfigManager.java +++ b/daemon/src/main/java/org/lsposed/lspd/service/ConfigManager.java @@ -96,7 +96,7 @@ public class ConfigManager { sqLiteDatabase -> Log.w(TAG, "database corrupted")); private boolean verboseLog = true; - private boolean dexObfuscate = false; + private boolean dexObfuscate = true; private boolean enableStatusNotification = true; private Path miscPath = null; @@ -263,7 +263,7 @@ public class ConfigManager { verboseLog = bool == null || (boolean) bool; bool = config.get("enable_dex_obfuscate"); - dexObfuscate = bool != null && (boolean) bool; + dexObfuscate = bool == null || (boolean) bool; bool = config.get("enable_auto_add_shortcut"); if (bool != null) { @@ -1023,9 +1023,8 @@ public class ConfigManager { // this is for manager and should not use the cache result boolean dexObfuscate() { - Map config = getModulePrefs("lspd", 0, "config"); - Object bool = config.get("enable_dex_obfuscate"); - return bool != null && (boolean) bool; + var bool = getModulePrefs("lspd", 0, "config").get("enable_dex_obfuscate"); + return bool == null || (boolean) bool; } public boolean enableStatusNotification() {