WeiguangTWK
/
LSPosed
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[core] Explicit `sv` for optimization (#1021)

This commit is contained in:
LoveSy 2021-08-27 19:13:02 +08:00 committed by GitHub
parent bc765d3cdd
commit 4eeadd02d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
core/src/main/cpp/daemon/logcat.cpp
View File

@ -5,6 +5,9 @@
#include <array> #include <array>
#include <cinttypes> #include <cinttypes>
#include "logcat.h" #include "logcat.h"
#include <string_view>
using namespace std::string_view_literals;
constexpr size_t kMaxLogSize = 32 * 1024 * 1024; constexpr size_t kMaxLogSize = 32 * 1024 * 1024;
@ -58,10 +61,10 @@ private:
bool verbose_ = true; bool verbose_ = true;
constexpr inline static auto start_verbose_inst_ = "!!start_verbose!!"; constexpr inline static auto kStartVerboseInst = "!!start_verbose!!"sv;
constexpr inline static auto stop_verbose_inst_ = "!!stop_verbose!!"; constexpr inline static auto kStopVerboseInst = "!!stop_verbose!!"sv;
constexpr inline static auto refresh_verbose_inst_ = "!!refresh_verbose!!"; constexpr inline static auto kRefreshVerboseInst = "!!refresh_verbose!!"sv;
constexpr inline static auto refresh_modules_inst_ = "!!refresh_modules!!"; constexpr inline static auto kRefreshModulesInst = "!!refresh_modules!!"sv;
}; };
int Logcat::PrintLogLine(const AndroidLogEntry &entry, FILE *out) { int Logcat::PrintLogLine(const AndroidLogEntry &entry, FILE *out) {
@ -114,26 +117,26 @@ void Logcat::ProcessBuffer(struct log_msg *buf) {
std::string_view tag(entry.tag, entry.tagLen); std::string_view tag(entry.tag, entry.tagLen);
bool shortcut = false; bool shortcut = false;
if (tag == "LSPosed-Bridge" || tag == "XSharedPreferences") [[unlikely]] { if (tag == "LSPosed-Bridge"sv || tag == "XSharedPreferences"sv) [[unlikely]] {
modules_print_count_ += PrintLogLine(entry, modules_file_.get()); modules_print_count_ += PrintLogLine(entry, modules_file_.get());
shortcut = true; shortcut = true;
} }
if (verbose_ && (shortcut || buf->id() == log_id::LOG_ID_CRASH || if (verbose_ && (shortcut || buf->id() == log_id::LOG_ID_CRASH ||
tag == "Magisk" || tag == "Magisk"sv ||
tag.starts_with("Riru") || tag.starts_with("Riru"sv) ||
tag.starts_with("LSPosed"))) [[unlikely]] { tag.starts_with("LSPosed"sv))) [[unlikely]] {
verbose_print_count_ += PrintLogLine(entry, verbose_file_.get()); verbose_print_count_ += PrintLogLine(entry, verbose_file_.get());
} }
if (entry.pid == getpid() && tag == "LSPosedLogcat") [[unlikely]] { if (entry.pid == getpid() && tag == "LSPosedLogcat"sv) [[unlikely]] {
std::string_view msg(entry.message, entry.messageLen); std::string_view msg(entry.message, entry.messageLen);
if (msg == start_verbose_inst_) { if (msg == kStartVerboseInst) {
verbose_ = true; verbose_ = true;
verbose_print_count_ += PrintLogLine(entry, verbose_file_.get()); verbose_print_count_ += PrintLogLine(entry, verbose_file_.get());
} else if (msg == stop_verbose_inst_) { } else if (msg == kStopVerboseInst) {
verbose_ = false; verbose_ = false;
} else if (msg == refresh_modules_inst_) { } else if (msg == kRefreshModulesInst) {
RefreshFd(false); RefreshFd(false);
} else if (msg == refresh_verbose_inst_) { } else if (msg == kRefreshVerboseInst) {
RefreshFd(true); RefreshFd(true);
} }
} }