[core] Remove redundant code (#65)

This commit is contained in:
双草酸酯 2021-02-04 03:23:48 +08:00 committed by GitHub
parent 0dbfe5ac35
commit 7757c5d19b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 13 deletions

View File

@ -35,26 +35,20 @@ namespace lspd {
constexpr int SHARED_RELRO_UID = 1037;
constexpr int PER_USER_RANGE = 100000;
void Context::CallPostFixupStaticTrampolinesCallback(void *class_ptr, jmethodID callback_mid) {
if (UNLIKELY(!callback_mid || !class_linker_class_)) {
return;
}
if (!class_ptr) {
void Context::CallOnPostFixupStaticTrampolines(void *class_ptr) {
if (UNLIKELY(!class_ptr || !class_linker_class_ || !post_fixup_static_mid_)) {
return;
}
JNIEnv *env;
vm_->GetEnv((void **) (&env), JNI_VERSION_1_4);
art::JNIEnvExt env_ext(env);
ScopedLocalRef clazz(env, env_ext.NewLocalRefer(class_ptr));
if (clazz != nullptr) {
JNI_CallStaticVoidMethod(env, class_linker_class_, callback_mid, clazz.get());
JNI_CallStaticVoidMethod(env, class_linker_class_, post_fixup_static_mid_, clazz.get());
}
}
void Context::CallOnPostFixupStaticTrampolines(void *class_ptr) {
CallPostFixupStaticTrampolinesCallback(class_ptr, post_fixup_static_mid_);
}
void Context::PreLoadDex(const fs::path &dex_path) {
if (LIKELY(!dexes.empty())) return;
@ -264,7 +258,7 @@ namespace lspd {
jfieldID path_fid = JNI_GetStaticFieldID(env, service_class, "CONFIG_PATH",
"Ljava/lang/String;");
jfieldID pn_fid = JNI_GetStaticFieldID(env, service_class, "INSTALLER_PACKAGE_NAME",
"Ljava/lang/String;");
"Ljava/lang/String;");
if (LIKELY(path_fid) && LIKELY(pn_fid)) {
env->SetStaticObjectField(service_class, path_fid, env->NewStringUTF(
ConfigManager::GetMiscPath().c_str()));

View File

@ -107,8 +107,6 @@ namespace lspd {
static jclass
FindClassFromLoader(JNIEnv *env, jobject class_loader, const char *class_name);
void CallPostFixupStaticTrampolinesCallback(void *class_ptr, jmethodID mid);
static bool
ShouldSkipInject(const std::string &package_name, uid_t user, uid_t uid, bool res,
const std::function<bool()>& empty_list,