[app] Manually call onViewCreated after call onCreateDialog (#1454)

This commit is contained in:
Howard Wu 2021-11-29 18:34:54 +08:00 committed by GitHub
parent 0af0f52072
commit cc19aa42c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 15 deletions

View File

@ -27,11 +27,8 @@ import android.content.pm.PackageManager;
import android.os.AsyncTask;
import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.View;
import android.widget.Toast;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.appcompat.app.AppCompatDialogFragment;
import androidx.fragment.app.FragmentManager;
@ -45,8 +42,6 @@ import java.lang.ref.WeakReference;
@SuppressWarnings("deprecation")
public class CompileDialogFragment extends AppCompatDialogFragment {
private ApplicationInfo appInfo;
public static void speed(FragmentManager fragmentManager, ApplicationInfo info) {
CompileDialogFragment fragment = new CompileDialogFragment();
fragment.setCancelable(false);
@ -60,7 +55,7 @@ public class CompileDialogFragment extends AppCompatDialogFragment {
@NonNull
public Dialog onCreateDialog(Bundle savedInstanceState) {
var arguments = getArguments();
appInfo = arguments != null ? arguments.getParcelable("appInfo") : null;
ApplicationInfo appInfo = arguments != null ? arguments.getParcelable("appInfo") : null;
if (appInfo == null) {
throw new IllegalStateException("appInfo should not be null.");
}
@ -72,14 +67,8 @@ public class CompileDialogFragment extends AppCompatDialogFragment {
.setView(binding.getRoot());
var alertDialog = builder.create();
onViewCreated(binding.getRoot(), savedInstanceState);
return alertDialog;
}
@Override
public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState);
new CompileTask(this).executeOnExecutor(App.getExecutorService(), appInfo.packageName);
return alertDialog;
}
private static class CompileTask extends AsyncTask<String, Void, Throwable> {

View File

@ -75,11 +75,12 @@ public class RecyclerViewDialogFragment extends AppCompatDialogFragment {
modulesFragment.installModuleToUser(module, user);
dialog.dismiss();
});
onViewCreated(binding.getRoot(), savedInstanceState);
return dialog;
}
@Override
public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
// prevent from overriding
public final void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState);
}
}